Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix macro transfer between verifiers in parallel branch verification #872

Merged
merged 7 commits into from
Sep 17, 2024
Merged

Fix macro transfer between verifiers in parallel branch verification #872

merged 7 commits into from
Sep 17, 2024

Conversation

marcoeilers
Copy link
Contributor

  • Simplifies the way we move function and macro declarations between prover instances when verifying different branches on different solvers in parallel
  • Gets rid of the stack of declared functions and macros in the Decider
  • Should improve performance of the relevant code for large examples (we used to do a lot of checks if a vector contains a value, now we check this on a HashSet)
  • Hopefully fixes some issues the more complex previous solution had in the process

@marcoeilers marcoeilers merged commit b737e36 into master Sep 17, 2024
4 checks passed
@marcoeilers marcoeilers deleted the meilers_fix_macro_declaration_order branch September 17, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marcoeilers